From 0d791575f884bea2bc28bd18b141e3defd34d9ad Mon Sep 17 00:00:00 2001 From: Dmitry Litvintsev Date: Mon, 27 Jan 2025 15:55:42 -0600 Subject: [PATCH] Bulk: PinManagerActivity do not set state of files that are pinned indefinitely to SKIPPED Motivaton: ---------- Setting files having infinite pin to state SKIPPED seems to prevents them from being staged if pool goes down. Modification: ------------- Set state to COMPLETED if pin lifetime is infinite. Result: ------ As tested and reported by DESY, the staging of files that happen to be on offline pools works properly Target: trunk Request: 10.2 Request: 9.2 Patch: https://rb.dcache.org/r/14365/ Require-notes: yes Require-book: no --- .../services/bulk/activity/plugin/pin/PinManagerActivity.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/modules/dcache-bulk/src/main/java/org/dcache/services/bulk/activity/plugin/pin/PinManagerActivity.java b/modules/dcache-bulk/src/main/java/org/dcache/services/bulk/activity/plugin/pin/PinManagerActivity.java index dcbbd8fbfd9..c8a95205245 100644 --- a/modules/dcache-bulk/src/main/java/org/dcache/services/bulk/activity/plugin/pin/PinManagerActivity.java +++ b/modules/dcache-bulk/src/main/java/org/dcache/services/bulk/activity/plugin/pin/PinManagerActivity.java @@ -112,9 +112,6 @@ public void handleCompletion(BulkRequestTarget target, Future future) { reply = getUninterruptibly(future); if (reply.getReturnCode() != 0) { target.setErrorObject(reply.getErrorObject()); - } else if (reply instanceof PinManagerPinMessage - && ((PinManagerPinMessage) reply).getLifetime() == -1L) { - target.setState(SKIPPED); } else { target.setState(State.COMPLETED); }