Skip to content

Commit

Permalink
Bulk: PinManagerActivity do not set state of files that are pinned in…
Browse files Browse the repository at this point in the history
…definitely to SKIPPED

Motivaton:
----------

Setting files having infinite pin to state SKIPPED seems to
prevents them from being staged if pool goes down.

Modification:
-------------

Set state to COMPLETED if pin lifetime is infinite.

Result:
------

As tested and reported by DESY, the staging of files that happen
to be on offline pools works properly

Target: trunk
Request: 10.2
Request: 9.2
Patch: https://rb.dcache.org/r/14365/

Require-notes: yes
Require-book: no
  • Loading branch information
DmitryLitvintsev authored and mksahakyan committed Jan 28, 2025
1 parent c7bd310 commit 0d79157
Showing 1 changed file with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ public void handleCompletion(BulkRequestTarget target, Future<Message> future) {
reply = getUninterruptibly(future);
if (reply.getReturnCode() != 0) {
target.setErrorObject(reply.getErrorObject());
} else if (reply instanceof PinManagerPinMessage
&& ((PinManagerPinMessage) reply).getLifetime() == -1L) {
target.setState(SKIPPED);
} else {
target.setState(State.COMPLETED);
}
Expand Down

0 comments on commit 0d79157

Please sign in to comment.