test(e2e): onboarding tests #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QZera
force-pushed
the
feat/onboarding-e2e-tests
branch
20 times, most recently
from
269a5cd to
aa7d5f2
Compare
QZera
force-pushed
the
feat/onboarding-e2e-tests
branch
9 times, most recently
from
8c5fb69 to
adfd2d2
Compare
QZera
force-pushed
the
feat/onboarding-e2e-tests
branch
12 times, most recently
from
304e9c9 to
bec020b
Compare
QZera
commented
Dec 27, 2024
QZera
force-pushed
the
feat/onboarding-e2e-tests
branch
from
bec020b to
ba33585
Compare
Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
- Refactors some tests in onboarding.spec.ts using `browser.waitUntil` to reduce flakiness - These assertions will now poll for the result instead of failing immediately - Simulates Radicle installation in the onboarding process by renaming the node home directory - Extracts common queries, actions, and assertions to helper files Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
QZera
force-pushed
the
feat/onboarding-e2e-tests
branch
from
983019b to
adf2a6d
Compare
maninak
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Please let me know if the single comment-assumption I've made is inaccurate and I'll insta-approve.
In general, and from a reader's perspective, I like how the testing architecture is shaping up, well done!
Naturally, I'll be able to form a more thorough verdict after I write a few tests of my own.
- Uses wdio's `onWorkerStart` hook to move the radicle directory before launching vscode - This is only done on the onboarding suite worker Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
QZera
force-pushed
the
feat/onboarding-e2e-tests
branch
from
9142baf to
cf74866
Compare
maninak
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite #169
Closes #163
.radiclefrom it's default locationbrowser.pause(used on some flaky tests) in favour of usingbrowser.waitUntil(asynchronous assertions). This should reduce overall flakiness when adding new tests to the suite.