Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(patch-detail): show patch status icon in webview panel #150

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

maninak
Copy link
Collaborator

@maninak maninak commented Jul 17, 2024

Closes no specific issue.

Signed-off-by: Konstantinos Maninakis <maninak@protonmail.com>
@maninak maninak added the enhancement New feature extending the app's current capabilities label Jul 17, 2024
@maninak maninak self-assigned this Jul 17, 2024
@maninak maninak merged commit 2d483b3 into main Jul 17, 2024
8 checks passed
@maninak maninak deleted the feat/patch-status-icon-in-webview-panel branch July 17, 2024 07:17
@maninak
Copy link
Collaborator Author

maninak commented Jul 17, 2024

Results:

The two left panels show the "before", all on their right show the "after" the changes of this PR.

image

🚀 Enhancements

  • patch-detail: replace generic file icon in webview panel with one that depicts the patch status

Bonus: state reactivity awesomesauce that came for free. See panel icon changing, even though it's in the background, in sync with webview contents and the Patches view item.

reactivity-over9K.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature extending the app's current capabilities
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant