Skip to content

Commit

Permalink
feat(patch-detail): don't show commit details in major events section
Browse files Browse the repository at this point in the history
Signed-off-by: Konstantinos Maninakis <maninak@protonmail.com>
  • Loading branch information
maninak committed Nov 9, 2024
1 parent a27c93e commit d361270
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,15 @@
- the aforementioned coupled with the pre-existing feature of optimally auto-aligning the form as it resizes should seamlessly provide a smooth authoring experience
- adjust the hover text of all form buttons to advertise their respective keyboard shortcut (if any)
- **patch-detail:** preselect the merged revision, if any, in the revision selector instead of always the latest
- **patch-detail:** don't mention the related commit in the patch major events section (~~"Last updated by W with revision X at commit Y Z time ago"~~). This information is still available in the Revision section.
- **patch-detail:** keep the labels of the main buttons (top-right of the view) as a single line of text, even if the viewport is narrow enough to compress them
- **patch-detail:** add themed styling to `<summary>` elements when tabbed into

### 🩹 Fixes

- **patch-detail:** don't disappear the Activity and Revision sections sometimes, e.g. when a new revision is detected
- **patch-detail:** make "Refresh" button work again, fetching latest patch data
- **patch-detail:** don't show extra gap between patch title and next section if description is empty
- **patch-detail:** don't show big gap between patch title and next section if the patch description is empty

### 🏡 Chores

Expand Down
8 changes: 2 additions & 6 deletions src/webviews/src/components/PatchMajorEvents.vue
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,7 @@ setInterval(() => {
<pre :title="latestMerge.author.id">{{ getIdentityAliasOrId(latestMerge.author) }}</pre>
using revision
<pre :title="latestMerge.revision">{{ shortenHash(latestMerge.revision) }}</pre>
<span v-if="!shouldShowRevisionEvent"
>at commit
<pre :title="latestMerge.commit">{{ shortenHash(latestMerge.commit) }}</pre></span
>&ensp;<wbr /><pre :title="getFormattedDate(latestMerge.timestamp, timeLocale)">{{
&ensp;<wbr /><pre :title="getFormattedDate(latestMerge.timestamp, timeLocale)">{{
mergedTimeAgo
}}</pre>
</div>
Expand All @@ -53,8 +50,7 @@ setInterval(() => {
getIdentityAliasOrId(latestRevision.author)
}}</pre>
with revision
<pre :title="latestRevision.id">{{ shortenHash(latestRevision.id) }}</pre> at commit
<pre :title="latestRevision.oid">{{ shortenHash(latestRevision.oid) }}</pre
<pre :title="latestRevision.id">{{ shortenHash(latestRevision.id) }}</pre
>&ensp;<wbr /><pre :title="getFormattedDate(latestRevision.timestamp, timeLocale)">{{
updatedTimeAgo
}}</pre>
Expand Down

0 comments on commit d361270

Please sign in to comment.