From c29da1e8c761d7b42400b22b515c62058bed3b90 Mon Sep 17 00:00:00 2001 From: Zacharias Fragkiadakis Date: Mon, 6 Jan 2025 11:24:37 +0200 Subject: [PATCH] style(e2e): move @skipLinuxCI from test cases to describe statement Signed-off-by: Zacharias Fragkiadakis --- test/e2e/specs/settings.spec.ts | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/test/e2e/specs/settings.spec.ts b/test/e2e/specs/settings.spec.ts index 3edbd49c..5e20a99d 100644 --- a/test/e2e/specs/settings.spec.ts +++ b/test/e2e/specs/settings.spec.ts @@ -88,7 +88,14 @@ describe('Settings', () => { }) }) - describe('VS Code, when updating the "Path to Radicle to Node Home" setting,', () => { + /** + * In Linux CI: + * - The extension is having issues resolving the correct node home directory (RAD_HOME). + * - Even when node home is set explicitly in the settings, the extension incorrectly reports it + * as non-authenticated. + */ + // eslint-disable-next-line max-len + describe('VS Code, when updating the "Path to Radicle to Node Home" setting, @skipLinuxCI', () => { let pathToNodeHomeSetting: Setting let outputView: OutputView @@ -113,13 +120,7 @@ describe('Settings', () => { await expectRadicleIdentityToBeFound(outputView) }) - /** - * In Linux CI: - * - The extension is having issues resolving the correct node home directory (RAD_HOME). - * - Even when set explicitly in the settings, the extension incorrectly reports it as - * non-authenticated. - */ - it('logs an error in the output console if the path is invalid @skipLinuxCI', async () => { + it('logs an error in the output console if the path is invalid', async () => { await outputView.clearText() await setTextSettingValue(pathToNodeHomeSetting, '/tmp') @@ -127,7 +128,7 @@ describe('Settings', () => { await expectRadicleProfileNotToBeFound(outputView) }) - it('recognizes when a valid path is specified @skipLinuxCI', async () => { + it('recognizes when a valid path is specified', async () => { await $`cp -r ${nodeHomePath} ${tempNodeHomePath}` await outputView.clearText() @@ -140,7 +141,7 @@ describe('Settings', () => { // This functionality does not seem to work // eslint-disable-next-line max-len - it.skip('recognizes if the directory is created *after* the setting is updated @skipLinuxCI', async () => { + it.skip('recognizes if the directory is created *after* the setting is updated', async () => { await outputView.clearText() await setTextSettingValue(pathToNodeHomeSetting, tempNodeHomePath)