Skip to content

Commit

Permalink
style(e2e): move @skipLinuxCI from test cases to describe statement
Browse files Browse the repository at this point in the history
Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
  • Loading branch information
QZera committed Jan 6, 2025
1 parent 98822c8 commit c29da1e
Showing 1 changed file with 11 additions and 10 deletions.
21 changes: 11 additions & 10 deletions test/e2e/specs/settings.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,14 @@ describe('Settings', () => {
})
})

describe('VS Code, when updating the "Path to Radicle to Node Home" setting,', () => {
/**
* In Linux CI:
* - The extension is having issues resolving the correct node home directory (RAD_HOME).
* - Even when node home is set explicitly in the settings, the extension incorrectly reports it
* as non-authenticated.
*/
// eslint-disable-next-line max-len
describe('VS Code, when updating the "Path to Radicle to Node Home" setting, @skipLinuxCI', () => {
let pathToNodeHomeSetting: Setting
let outputView: OutputView

Expand All @@ -113,21 +120,15 @@ describe('Settings', () => {
await expectRadicleIdentityToBeFound(outputView)
})

/**
* In Linux CI:
* - The extension is having issues resolving the correct node home directory (RAD_HOME).
* - Even when set explicitly in the settings, the extension incorrectly reports it as
* non-authenticated.
*/
it('logs an error in the output console if the path is invalid @skipLinuxCI', async () => {
it('logs an error in the output console if the path is invalid', async () => {
await outputView.clearText()

await setTextSettingValue(pathToNodeHomeSetting, '/tmp')

await expectRadicleProfileNotToBeFound(outputView)
})

it('recognizes when a valid path is specified @skipLinuxCI', async () => {
it('recognizes when a valid path is specified', async () => {
await $`cp -r ${nodeHomePath} ${tempNodeHomePath}`
await outputView.clearText()

Expand All @@ -140,7 +141,7 @@ describe('Settings', () => {

// This functionality does not seem to work
// eslint-disable-next-line max-len
it.skip('recognizes if the directory is created *after* the setting is updated @skipLinuxCI', async () => {
it.skip('recognizes if the directory is created *after* the setting is updated', async () => {
await outputView.clearText()

await setTextSettingValue(pathToNodeHomeSetting, tempNodeHomePath)
Expand Down

0 comments on commit c29da1e

Please sign in to comment.