test(e2e): extract backup node home path into constants

Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
cytechmobile · Jan 7, 2025 · 9142baf · 9142baf
1 parent 4747d92
commit 9142baf
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/test/e2e/constants/config.ts b/test/e2e/constants/config.ts
@@ -17,3 +17,10 @@ export const rootDirPath = join(__dirname, '../../..')
  * configuration and data.
  */
 export const nodeHomePath = process.env['RAD_HOME']
+
+/**
+ * The path to a backup node home directory. This is used to store the original
+ * node home directory for tests that require the original path to be moved or
+ * modified.
+ */
+export const backupNodeHomePath = `${nodeHomePath}.backup`
diff --git a/test/e2e/specs/onboarding.spec.ts b/test/e2e/specs/onboarding.spec.ts
@@ -7,7 +7,7 @@ import isEqual from 'lodash/isEqual'
 import { expectStandardSidebarViewsToBeVisible } from '../helpers/assertions'
 import { openRadicleViewContainer } from '../helpers/actions'
 import { getFirstWelcomeViewText } from '../helpers/queries'
-import { e2eTestDirPath, nodeHomePath } from '../constants/config'
+import { backupNodeHomePath, e2eTestDirPath, nodeHomePath } from '../constants/config'
 
 describe('Onboarding Flow', () => {
   let workbench: Workbench
@@ -17,10 +17,8 @@ describe('Onboarding Flow', () => {
   })
 
   describe('VS Code, *before* Radicle is installed,', () => {
-    const tempPathToNodeHome = `${nodeHomePath}.temp`
-
     after(async () => {
-      await $`mv ${tempPathToNodeHome} ${nodeHomePath}`
+      await $`mv ${backupNodeHomePath} ${nodeHomePath}`
       await workbench.executeCommand('Developer: Reload Window')
     })
 

diff --git a/test/e2e/wdio.conf.ts b/test/e2e/wdio.conf.ts
@@ -1,7 +1,12 @@
 import path from 'node:path'
 import { $ } from 'zx'
 import type { Options } from '@wdio/types'
-import { e2eTestDirPath, nodeHomePath, rootDirPath } from './constants/config'
+import {
+  backupNodeHomePath,
+  e2eTestDirPath,
+  nodeHomePath,
+  rootDirPath,
+} from './constants/config'
 
 // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports
 const packageJson = require('../../package.json')
@@ -58,7 +63,7 @@ export const config: Options.Testrunner = {
   },
   onWorkerStart: async (_cid, _caps, specs) => {
     if (specs.some((spec) => spec.includes('onboarding.spec.ts'))) {
-      await $`mv ${nodeHomePath} ${`${nodeHomePath}.temp`}`
+      await $`mv ${nodeHomePath} ${backupNodeHomePath}`
     }
   },
 }