Skip to content

Commit

Permalink
fix(patch-detail): use better icon and copy for "Reveal" button
Browse files Browse the repository at this point in the history
Signed-off-by: Konstantinos Maninakis <maninak@protonmail.com>
  • Loading branch information
maninak committed Jul 2, 2024
1 parent 83b3e7a commit 3ca69d6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@
- if Escape key is pressed editing stops. The current changes get stored as a draft that will be reused if editing is restarted along the same VS Code usage session
- **webview:** make webviews like the one for patch details reactively adapt their UI state when any extension state they depend on is updated e.g. patch checked-out indicator between the patch list and patch detail view
- **commands:** use the name of the tracked upstream branch of the currently checked out branch, instead of just the latter, when trying to detect if a radicle patch is currently checked out
- **patch-detail:** use a better icon and improved hover copy for "Reveal" button

### 🩹 Fixes

- **patch-list:** show check-out state per patch item always reflecting git state. Previously a checked out patch would not have the associated checkmark denoting its state shown in the patches list unless a check out AND a list refresh was done.
- **commands:** don't fail checking out patch branch if the branch already existed but was referring to a different revision than the one we're attempting to check out
- **patch-detail:** the buttons on patch detail webviews left open from a previous VS Code session that got restored will now work, same as those of just opened webviews
- **patch-detail:** use a better icon and improved hover copy for "Reveal" button
- **webview:** make webview restoration across sessions more robust and less likely to result in an blank panel
- **config:** watch _user-defined_ path to Radicle CLI binary for changes too. Previously only the default paths per OS were being watched.
- **onboarding:** detect Radicle CLI binary installation change even if file or parent directory tree is missing on extension's initialization
Expand Down
4 changes: 2 additions & 2 deletions src/webviews/src/components/PatchDetailButtons.vue
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ function revealPatch() {
<vscode-button
class="self-center"
appearance="secondary"
title="Reveal in Patches View"
title="Reveal Patch Among Those Listed in the Patches View"
@click="revealPatch"
>
<!-- eslint-disable-next-line vue/no-deprecated-slot-attribute -->
<span slot="start" class="codicon codicon-export"></span>Reveal</vscode-button
<span slot="start" class="codicon codicon-go-to-search"></span>Reveal</vscode-button
>
</template>

0 comments on commit 3ca69d6

Please sign in to comment.