Fake pull request #240

Stelios123 · 2023-04-28T09:12:19Z

GitHub Metadata

Number	Created On	Created By	Assignees
#5	Jun 08, 2023 08:33:48 UTC	gsaslis	Archimidis

The concourse implementation:

relies on a pre-downloaded fly CLI from the concourse server that the CI broker has been configured with

with that in place, it has 3 (or maybe 2) roles to fill:

Setup: Create and unpause a pipeline in concourse

acquires token from concourse with fly login
- need some kind of mechanism that handles re-authenticating / authentication errors (and re-logins).
creates pipeline (more on this later)

Trigger jobs

There are 2 alternative approaches we are considering:

let the broker trigger the jobs (using the fly CLI or concourse HTTP API)
set up a pipeline in concourse that uses a git resource to watch for events triggering the pipeline. This has the added benefit that we don't need to do the triggering, but we would still need to find out about these events somehow, so we can watch for them later on and update the job status.

Triggering should only trigger the job in concourse without watching for the output. We need to capture the build ID from the output and then add this build ID to a data structure of "patches with pending builds".

Watch for results and update Patch with outcome

In terms of watching for the results, we should create some worker thread pool that:

looks at pending builds
for each build, uses some polling policy on the job status endpoint to verify whether the build has finished (whether failed or succeeded)
once the job has finished, it is time to update the patch with a comment.

In terms of "updating the Patch", we will be adding a simple comment to the Patch for now.

NOTES:

it might make sense to use the API that the fly CLI and web app uses as opposed to wrapping the fly CLI itself.
try to maintain flat hierarchy of projects (under which pipelines get created) in concourse to match flat hierarchy in radicle
we don't want to persist job logs in radicle (can get very messy - very fast)
we discussed at length about what would be the best way to expose a ci_server-agnostic HTTP API endpoint that can be used by clients (web, etc.) to show job status, etc. Most preferred approach for the time being is to have the radicle-ci-broker write to an sqlite database the information about pending jobs and for radicle-httpd to read from that (with an added benefit that the rad cli could then read that information and incorporate that into the Terminal User Interface (TUI).

Signed-off-by: Stelios Mavrommatakis <steliosmavr@cytech.gr>

manolisziCy · 2023-04-28T09:17:12Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/actions/rad/RadRemote.java

@@ -14,7 +14,7 @@ public RadRemote(GitRepository repo) {

    @Override
    public String getActionName() {
-        return "Remote";
+        return "Remotee";


do this "Remote"

manolisziCy · 2023-04-28T09:17:24Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/config/RadicleSettingsView.java

@@ -130,14 +130,14 @@ private boolean isRadHomeValidPath(String radPath, String radHome) {
    private void unlockOrCreateIdentity() {
        msgLabel.setText("");
        ApplicationManager.getApplication().executeOnPooledThread(() -> {
-            var radHome = getPathFromTextField(radHomeField);
+            var radHome =  getPathFromTextField(radHomeField);


delete spaces

manolisziCy · 2023-04-28T09:17:31Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/config/RadicleSettingsView.java

            var radPath = getPathFromTextField(radPathField);
-            var radSelf = new RadSelf(radHome, radPath, myProject);
+            var radSelf =  new RadSelf(radHome, radPath, myProject);


delete spaces

manolisziCy · 2023-05-11T12:19:22Z

Hey

hey

Stelios123 · 2023-10-26T07:21:36Z

chrome_klSdi30WtV.mp4

Stelios123 · 2023-10-26T07:23:11Z

test.txt

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/actions/rad/RadAuth.java

Stelios123 · 2023-11-30T09:43:01Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/actions/rad/RadAuth.java

@@ -31,7 +31,9 @@ public String getActionName() {
            return "AuthCreateIdentity";
        } else if (action == RadAuthAction.UNLOCKED_IDENTITY) {
            return "AuthUnlockedIdentity";


Stelios123 · 2023-12-04T14:27:56Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/actions/rad/RadAuth.java

-        }
+        } else if (action == RadAuthAction.UNLOCKED_IDENTITY) {
+        return "AuthUnlockedIdentity";
+    }
        return "";


Stelios123 · 2023-12-04T14:29:25Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/actions/rad/RadAuth.java

-        }
+        } else if (action == RadAuthAction.UNLOCKED_IDENTITY) {
+        return "AuthUnlockedIdentity";
+    }
        return "";
    }



Stelios123 · 2023-12-04T14:39:28Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/actions/rad/RadAuth.java

@@ -31,7 +31,9 @@ public String getActionName() {
            return "AuthCreateIdentity";
        } else if (action == RadAuthAction.UNLOCKED_IDENTITY) {
            return "AuthUnlockedIdentity";
-        }
+        } else if (action == RadAuthAction.UNLOCKED_IDENTITY) {


Signed-off-by: Stelios Mavrommatakis <steliosmavr@cytech.gr>

Stelios123 · 2023-12-11T10:36:06Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/actions/rad/RadRemote.java

+    @Override
+    public String getActionName() {
+        return "";
+    }


change this

Stelios123 · 2023-12-11T10:36:15Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/actions/rad/RadRemote.java

+    public String getActionName() {
+        return "";
+    }
+
    public List<Peer> findTrackedPeers() {
        var out = this.perform();


Signed-off-by: Stelios Mavrommatakis <steliosmavr@cytech.gr>

Stelios123 · 2023-12-11T10:38:09Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/actions/rad/RadRemote.java

-    @Override
-    public String getActionName() {
-        return "Remote";
-    }

    @Override
    public ProcessOutput run() {


Signed-off-by: Stelios Mavrommatakis <steliosmavr@cytech.gr>

Stelios123 · 2023-12-18T19:38:57Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/actions/rad/RadAuth.java

@@ -31,7 +31,9 @@ public String getActionName() {
            return "AuthCreateIdentity";
        } else if (action == RadAuthAction.UNLOCKED_IDENTITY) {
            return "AuthUnlockedIdentity";


Installation

Stelios123 · 2024-01-29T10:32:51Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/actions/rad/RadAuth.java

@@ -31,7 +31,9 @@ public String getActionName() {
            return "AuthCreateIdentity";
        } else if (action == RadAuthAction.UNLOCKED_IDENTITY) {
            return "AuthUnlockedIdentity";
-        }


Stelios123

test

Stelios123 · 2024-04-09T09:12:05Z

my comment

KostasC22 · 2024-04-09T09:22:55Z

Dokimastiko comment

Stelios123 · 2024-04-09T09:24:04Z

Dokimastiko commentt

hello

Signed-off-by: stelios maurommatakis <steliosmavr@cytech.gr>

Stelios123 · 2024-05-30T07:45:55Z

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/initial.txt

@@ -0,0 +1 @@
+test file


test comment

Signed-off-by: stelios maurommatakis <steliosmavr@cytech.gr>

Stelios123 added 3 commits April 28, 2023 12:09

Add one more if

bb6d3d5

Signed-off-by: Stelios Mavrommatakis <steliosmavr@cytech.gr>

Add spaces

79cb7dc

Signed-off-by: Stelios Mavrommatakis <steliosmavr@cytech.gr>

Change remote -> Remotee

24a8e59

Signed-off-by: Stelios Mavrommatakis <steliosmavr@cytech.gr>

manolisziCy requested changes Apr 28, 2023

View reviewed changes

JChrist marked this pull request as draft May 2, 2023 05:25

Stelios123 assigned giorgosap, Stelios123, anastasiapal and ealefrag and unassigned Stelios123, giorgosap, ealefrag and anastasiapal Jul 4, 2023

Stelios123 requested review from giorgosap and removed request for giorgosap July 6, 2023 09:50

Stelios123 assigned giorgosap and unassigned giorgosap Jul 7, 2023

Stelios123 changed the title ~~Fake pull request~~ Start broker as a new process that listens to node events Sep 12, 2023

Stelios123 changed the title ~~Start broker as a new process that listens to node events~~ Fake pull request Sep 12, 2023

Stelios123 commented Nov 30, 2023

View reviewed changes

src/main/java/network/radicle/jetbrains/radiclejetbrainsplugin/actions/rad/RadAuth.java Show resolved Hide resolved

Stelios123 commented Nov 30, 2023

View reviewed changes

Stelios123 commented Dec 4, 2023

View reviewed changes

changes

a39b282

Signed-off-by: Stelios Mavrommatakis <steliosmavr@cytech.gr>

Stelios123 commented Dec 11, 2023

View reviewed changes

changes

a8743b2

Signed-off-by: Stelios Mavrommatakis <steliosmavr@cytech.gr>

Stelios123 commented Dec 11, 2023

View reviewed changes

changes

79102f8

Signed-off-by: Stelios Mavrommatakis <steliosmavr@cytech.gr>

Stelios123 commented Dec 18, 2023

View reviewed changes

Stelios123 commented Jan 29, 2024

View reviewed changes

Stelios123 commented Mar 20, 2024

View reviewed changes

add new file

2bf08ea

Signed-off-by: stelios maurommatakis <steliosmavr@cytech.gr>

Stelios123 commented May 30, 2024

View reviewed changes

Stelios123 added 2 commits May 30, 2024 10:46

rename new file

7991f1d

Signed-off-by: stelios maurommatakis <steliosmavr@cytech.gr>

delete new file

ae4c252

Signed-off-by: stelios maurommatakis <steliosmavr@cytech.gr>

Stelios123 force-pushed the fakeBranch branch from dcefb3c to ae4c252 Compare May 30, 2024 08:02

Stelios123 added 2 commits May 30, 2024 11:29

rename file from RadRemote to RadRemote12

e3ff13e

Signed-off-by: stelios maurommatakis <steliosmavr@cytech.gr>

Rename file

14e1887

Signed-off-by: stelios maurommatakis <steliosmavr@cytech.gr>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fake pull request #240

Fake pull request #240

Stelios123 commented Apr 28, 2023 •

edited

Loading

manolisziCy Apr 28, 2023

Stelios123 Dec 1, 2023

manolisziCy Apr 28, 2023

manolisziCy Apr 28, 2023

manolisziCy commented May 11, 2023

Stelios123 commented Oct 26, 2023

Stelios123 commented Oct 26, 2023

Stelios123 Nov 30, 2023

Stelios123 Dec 4, 2023

Stelios123 Dec 4, 2023

Stelios123 Dec 4, 2023

Stelios123 Dec 11, 2023

Stelios123 Dec 11, 2023

Stelios123 Dec 11, 2023

Stelios123 Dec 18, 2023

Stelios123 Jan 29, 2024

Stelios123 left a comment

Stelios123 commented Apr 9, 2024

KostasC22 commented Apr 9, 2024

Stelios123 commented Apr 9, 2024 •

edited

Loading

Stelios123 May 30, 2024

Fake pull request #240

Are you sure you want to change the base?

Fake pull request #240

Conversation

Stelios123 commented Apr 28, 2023 • edited Loading

Setup: Create and unpause a pipeline in concourse

Trigger jobs

Watch for results and update Patch with outcome

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

manolisziCy commented May 11, 2023

Stelios123 commented Oct 26, 2023

Stelios123 commented Oct 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Installation

Choose a reason for hiding this comment

Stelios123 left a comment

Choose a reason for hiding this comment

Stelios123 commented Apr 9, 2024

KostasC22 commented Apr 9, 2024

Stelios123 commented Apr 9, 2024 • edited Loading

Choose a reason for hiding this comment

Stelios123 commented Apr 28, 2023 •

edited

Loading

Stelios123 commented Apr 9, 2024 •

edited

Loading