-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change references and bump dependencies #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think large scale changes in this PR (formatting, change in import path in go files etc) will make it really tough to merge any future upstream changes (even though we don't expect a lot of those). My suggestion would be to not touch the go files at all (except where we make the functionality change).
The import path change should be achieved using replace directives in the respective go.mod files rather than changing the .go files themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - please check the minor comment for the Dockerfile. I presume this builds correctly and you tested a sample run as well?
This PR contains the following changes:
1.22
main
to follow conventions of all our other branches (sole reason)