Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change references and bump dependencies #2

Merged
merged 11 commits into from
Sep 11, 2024
Merged

Conversation

wcmjunior
Copy link

@wcmjunior wcmjunior commented Sep 4, 2024

This PR contains the following changes:

  • Bump golang to 1.22
  • Bump all the dependencies to the latest available versions
  • Improve docs readability and add a disclaimer about the reason for this fork
  • Add Dependabot
  • Changes the default branch to main to follow conventions of all our other branches (sole reason)
  • Get CI to work

@wcmjunior wcmjunior marked this pull request as draft September 4, 2024 22:13
@wcmjunior wcmjunior marked this pull request as ready for review September 5, 2024 05:19
@wcmjunior wcmjunior changed the title Bump dependencies Change references and bump dependencies Sep 5, 2024
Copy link

@yoursnerdly yoursnerdly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think large scale changes in this PR (formatting, change in import path in go files etc) will make it really tough to merge any future upstream changes (even though we don't expect a lot of those). My suggestion would be to not touch the go files at all (except where we make the functionality change).

The import path change should be achieved using replace directives in the respective go.mod files rather than changing the .go files themselves.

Copy link

@yoursnerdly yoursnerdly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please check the minor comment for the Dockerfile. I presume this builds correctly and you tested a sample run as well?

@wcmjunior wcmjunior merged commit 6c1b3f4 into main Sep 11, 2024
1 check passed
@wcmjunior wcmjunior deleted the chore/bump-dependencies branch September 11, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants