Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-13650: Add Helm parameters to README and pre-commit config to autogenerate docs #2

Merged
merged 1 commit into from
Mar 29, 2024
Merged

ENG-13650: Add Helm parameters to README and pre-commit config to autogenerate docs #2

merged 1 commit into from
Mar 29, 2024

Conversation

antoniomrfranco
Copy link
Collaborator

@antoniomrfranco antoniomrfranco commented Mar 25, 2024 •
edited
Loading

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

Description of testing

@antoniomrfranco antoniomrfranco merged commit 2550d8d into feature/ENG-13649 Mar 29, 2024
2 checks passed
@antoniomrfranco antoniomrfranco deleted the feat/ENG-13650 branch March 29, 2024 14:49
antoniomrfranco added a commit that referenced this pull request Jun 26, 2024
@antoniomrfranco @wcmjunior
ENG-13649: Add initial Helm template (#1)
2fdf66a 
* Add initial Helm template

* Update ports to use map instead of list of int

* Update Snowflake values

* Some fixes after testing

* Update README and add pre-commit script (#2)

* Add deployment properties (#3)

* Bump sidecar version & fix typo

* Add Role and RoleBinding

* Delete templates/ingress.yaml

* Set CYRAL_SIDECAR_DEPLOYMENT_PROPERTIES env

* Add license to missing files

* Fix typo on error msg

* Keep existing certs on updates

* Use same index pattern for all ports

* Place Cyral parameters docs close to helm values

* Remove support for old K8s versions

* Add permissions to get/watch secrets

* Add newline at end of files

* Update default registry and repository

* Update docs with required secret keys

* Simplify Snowflake envs

---------

Co-authored-by: Wilson de Carvalho <796900+wcmjunior@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antoniomrfranco