Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hpa resource #13

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Add hpa resource #13

merged 1 commit into from
Feb 3, 2025

Conversation

day1118
Copy link
Contributor

@day1118 day1118 commented Feb 3, 2025 •
edited
Loading

Description of the change

Add pha resource

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

Deployed and increased CPU to see scaling

Yaswanth-cyral
Yaswanth-cyral approved these changes Feb 3, 2025
View reviewed changes
Copy link

@Yaswanth-cyral Yaswanth-cyral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this changes

nvemula-cyral
nvemula-cyral approved these changes Feb 3, 2025
View reviewed changes
Copy link

@nvemula-cyral nvemula-cyral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@day1118 I am just approving to keep this rolling, not familiar enough to do actual review. @antoniomrfranco pls review in your daytime

@day1118 day1118 merged commit fd24060 into main Feb 3, 2025
@day1118 day1118 deleted the feat/add-hpa branch February 3, 2025 06:15
day1118 added a commit that referenced this pull request Feb 3, 2025
@day1118
Add hpa resource (#13)
3116e0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvemula-cyral nvemula-cyral nvemula-cyral approved these changes

@Yaswanth-cyral Yaswanth-cyral Yaswanth-cyral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@day1118 @nvemula-cyral @Yaswanth-cyral