Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-13649: Add initial Helm template #1

Merged
merged 21 commits into from
Jun 26, 2024
Merged

Conversation

antoniomrfranco
Copy link
Collaborator

@antoniomrfranco antoniomrfranco commented Mar 13, 2024

Description of the change

Helm template to deploy the single container sidecar on Kubernetes.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

  • Deployed to multiple K8s environments: minikube, GKE, and EKS.

@antoniomrfranco antoniomrfranco marked this pull request as draft March 13, 2024 17:57
@antoniomrfranco antoniomrfranco marked this pull request as ready for review April 1, 2024 18:42
@antoniomrfranco antoniomrfranco requested a review from jrich523 June 11, 2024 17:02
Copy link

@ptcar2009 ptcar2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, some general comments and questions.

One thing that jumped to me is, are we planning on running any CI on this? We could do some chart testing and further linting, as we do in the control plane. You could use something similar to this: https://github.com/cyralinc/controlplane-templates/pull/2973/files#diff-e6063f06e3a63c0129659d95ef7bab13593d05cb60671234d42005e30e97fc9a

@jrich523
Copy link

any reason for the inconsistency in the copyright on the files? seems like some have it and others dont?

Copy link

@ptcar2009 ptcar2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antoniomrfranco antoniomrfranco merged commit 2fdf66a into main Jun 26, 2024
1 check passed
@antoniomrfranco antoniomrfranco deleted the feature/ENG-13649 branch June 26, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants