-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-13649: Add initial Helm template #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, some general comments and questions.
One thing that jumped to me is, are we planning on running any CI on this? We could do some chart testing and further linting, as we do in the control plane. You could use something similar to this: https://github.com/cyralinc/controlplane-templates/pull/2973/files#diff-e6063f06e3a63c0129659d95ef7bab13593d05cb60671234d42005e30e97fc9a
any reason for the inconsistency in the copyright on the files? seems like some have it and others dont? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description of the change
Helm template to deploy the single container sidecar on Kubernetes.
Type of change
Checklists
Development
Code review
Testing