Skip to content

Commit

Permalink
NEWS and CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
krlmlr committed Apr 25, 2021
1 parent 9e5ea3d commit 0096481
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 21 deletions.
30 changes: 16 additions & 14 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,29 @@

# dm 0.1.13

- Move repository to <https://github.com/cynkra/dm> (#500).
- Test DuckDB on GitHub Actions (#498).

## Features

# dm 0.1.12.9002
- `dm_draw()` gains `column_types` argument, if `TRUE` the column type is shown for each displayed column (#444, @samssann).
- `copy_dm_to()` gains `schema` argument (#432).
- `dm_from_src()` gains `dbname` argument for MSSQL (#472).

- Fix description of filtering behavior in `?dm_zoom_to` (#403).
## Bug fixes

- Fix `rows_update()` when multiple columns are updated (#488, @samssann).

# dm 0.1.12.9001
## Performance

- Enable more Postgres tests (#497).
- `enum_fk_candidates()` now only checks distinct values, this improves performance for large tables. As a consequence, only the number of distinct values is reported for mismatches, not the number of mismatching rows/entries (#494).
- Fix `rows_update()` when multiple columns are updated (#488, @samssann).
- `dm_draw()` gains `column_types` argument, if `TRUE` the column type is shown for each displayed column (#444, @samssann).
- `copy_dm_to()` gains `schema` argument (#432).

## Documentation

# dm 0.1.12.9000
- Fix description of filtering behavior in `?dm_zoom_to` (#403).

- `dm_from_src()` gains `dbname` argument for MSSQL (#472).
## Internal

- Move repository to <https://github.com/cynkra/dm> (#500).
- Enable more Postgres tests (#497).
- Test DuckDB on GitHub Actions (#498).


# dm 0.1.12
Expand Down Expand Up @@ -414,7 +416,7 @@ Initial GitHub release.
- `cdm_check_for_pk_candidates()`

## Foreign keys

- `cdm_add_fk()`
- `cdm_has_fk()`
- `cdm_get_fk()`
Expand All @@ -430,7 +432,7 @@ Initial GitHub release.
- `cdm_get_available_colors()`

## Flattening

- `cdm_join_tbl()`

## Filtering
Expand Down
12 changes: 5 additions & 7 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,20 @@ dm 0.1.13

## Cran Repository Policy

- [ ] Reviewed CRP last edited 2021-04-25.
- [x] Reviewed CRP last edited 2021-04-25.

See changes at https://github.com/eddelbuettel/crp/compare/master@%7B2020-10-29%7D...master@%7B2021-04-25%7D

## R CMD check results

- [x] Checked locally, R 4.0.5
- [ ] Checked on CI system, R 4.0.5
- [ ] Checked on win-builder, R devel
- [x] Checked on CI system, R 4.0.5
- [x] Checked on win-builder, R devel

Check the boxes above after successful execution and remove this line. Then run `fledge::release()`.

## Current CRAN check results

- [x] Checked on 2021-04-25, problems found: https://cran.r-project.org/web/checks/check_results_dm.html
- [ ] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-ix86+x86_64, r-patched-linux-x86_64
- [ ] ERROR: r-devel-windows-x86_64-gcc10-UCRT

Check results at: https://cran.r-project.org/web/checks/check_results_dm.html
- [x] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-ix86+x86_64, r-patched-linux-x86_64: Fixed
- [x] ERROR: r-devel-windows-x86_64-gcc10-UCRT: Error with build system

0 comments on commit 0096481

Please sign in to comment.