media methods now use the media name instead of the function name #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszulik
force-pushed
the
fix/media-methods
branch
from
7771cb3 to
e321d62
Compare
…of the media name
mszulik
force-pushed
the
fix/media-methods
branch
from
e321d62 to
7b84102
Compare
mszulik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some problems that arise with this:
Jörn said he sees no need in this feature as the media belongs to the model structure and should not be changed dynamically, it can be seen similar to database fields. In his opinion the available media should not be dynamic and this feature should be scrapped.
See https://github.com/cybex-gmbh/maminator-server/pull/5 for an implementation using a dynamically assigned media name.