Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages are reorganized to improve logical order #155

Open
3 tasks
izgeri opened this issue Apr 29, 2020 · 0 comments
Open
3 tasks

Packages are reorganized to improve logical order #155

izgeri opened this issue Apr 29, 2020 · 0 comments

Comments

@izgeri
Copy link
Contributor

izgeri commented Apr 29, 2020

This project has evolved to a point where the packages could use an effort to reorganize them so they are more logically distinct units. For example,

  • the github package includes suite-related info (eg SuiteComponent and SuiteCategory) that may be better relegated to its own package
  • the repositories package really includes info pulled from the suite.yml, eg config, section, and category - it's not a pure library for aggregating info about repositories
  • the template package leverages the github.SuiteCategories object that should probably come from a package other than github

In addition, the templates test "is at the far edge of explicit test data definition bulk limit" -- @sgnn7, and should maybe be refactored as part of this effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant