Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of docs-release templating #50

Closed
3 tasks
sgnn7 opened this issue May 21, 2020 · 1 comment
Closed
3 tasks

Fix usage of docs-release templating #50

sgnn7 opened this issue May 21, 2020 · 1 comment
Labels
component/suite kind/bug

Comments

@sgnn7
Copy link
Contributor

sgnn7 commented May 21, 2020

Summary

Currently when we use html templates, they are not using html/template package but text/template and thus not loading the partials either.

Steps to Reproduce

  • Run ./parse-changelogs -t docs-release

Expected Results

All output should follow html/template pattern where needed

Actual Results (including error logs, if applicable)

Output uses plain text/template transformation

Acceptance Criteria

  • Ensure html templates use the proper template package
  • Ensure html partials can work in integration test(s)
  • Ensure that (if merged at that time) installation instructions for Conjur are moved to a partial
sgnn7 added a commit to cyberark/conjur-oss-suite-release that referenced this issue May 21, 2020
@sgnn7
Added installation instructions to release docs artifacts
bee6cae 
This change adds installation instructions to generated `docs-release`
artifacts as they are needed there for our users. This change required a
bit deeper tests changes as we needed to hit more logic branches in the
templates to test properly.

It should be noted that this extra info should ideally be done as a
partial just like it is in the markdown templates but we cannot do that
until cyberark/conjur-oss-helm-chart#50 is
fixed.
sgnn7 added a commit to cyberark/conjur-oss-suite-release that referenced this issue May 26, 2020
@sgnn7
Added installation instructions to release docs artifacts
63c87d6 
This change adds installation instructions to generated `docs-release`
artifacts as they are needed there for our users. This change required a
bit deeper tests changes as we needed to hit more logic branches in the
templates to test properly.

It should be noted that this extra info should ideally be done as a
partial just like it is in the markdown templates but we cannot do that
until cyberark/conjur-oss-helm-chart#50 is
fixed.
@izgeri
Copy link
Contributor

izgeri commented Dec 30, 2020

Filed in wrong repo - moved to cyberark/conjur-oss-suite-release#205

@izgeri izgeri closed this as completed Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/suite kind/bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgnn7 @izgeri