Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple patches-files or patches-file with root patches together #581

Closed
4 tasks done
sascha-meissner opened this issue Jun 11, 2024 · 3 comments
Closed
4 tasks done
Labels
enhancement New features, options, or other additions.

Comments

@sascha-meissner
Copy link

Verification

  • I have updated Composer to the most recent stable release (composer self-update)
  • I have updated Composer Patches to the most recent stable release (composer update cweagans/composer-patches)
  • I am using one of the supported PHP versions (8.0+)
  • I have searched existing issues and discussions for my idea.

Is your feature request related to a problem?

Currently you can either choose to have one patches-file containing the patches OR having the patches in the root composer json,

if you try to use:

        "patches": {
            "some/package": {
                "do-this-and-that": "path/to/my.patch"
            }
        },
        "patches-file": "composer.patches.json"

it will ignore the patches-file no matter the order.

BUT it would be a very nice feature to have multiple patch-sources, in example to have a centralized patchmanagement and still have the possibility to have exotic project-specific patches only in the project and not in the central.

Describe your proposed solution(s)

Either support multiple patchfiles, in example:

"patches-file": ["upstream.patches.json", "custom.patches.json"]

which would be the desired solution

Describe alternatives

for our use case two-dimensional approach would also work in example when having

        "patches": {
            "some/package": {
                "do-this-and-that": "path/to/my.patch"
            }
        },
        "patches-file": "composer.patches.json"

that both, the patches in root composer json will be applied as well as the patches in patches file

Additional context

No response

@sascha-meissner sascha-meissner added the enhancement New features, options, or other additions. label Jun 11, 2024
Copy link

👋 Thanks for the idea! Please remember that this is an open source project - feature requests may or may not be implemented, and if they are, the timeline is unknown. If you need a guaranteed implementation or timeline, sponsorships are welcome!

@sascha-meissner
Copy link
Author

I´m sorry i didnt find #139 in the first place, this issue here should be a duplicate

@cweagans
Copy link
Owner

2.x does what you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features, options, or other additions.
Projects
None yet
Development

No branches or pull requests

2 participants