Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cibuildwheel to 2.19.2 and ci pipeline #52

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

B1ueber2y
Copy link
Member

@B1ueber2y B1ueber2y commented Jul 31, 2024

Align with COLMAP colmap/colmap#2632, colmap/colmap#2634.

Otherwise, with inconsistent pip wheels, the customized manifold PositiveExponentialManifold introduced in colmap/colmap#2621 and potential future new manifold support will break, and even pycolmap will break when pyceres is installed.

Bug logs before the fix:

(test) shaoliu@cvg-desktop-56:~$ python -c "import pycolmap; print(pycolmap.__version__)"
3.11.0
(test) shaoliu@cvg-desktop-56:~$ pip install pyceres
Collecting pyceres
  Using cached pyceres-2.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (2.1 kB)
Requirement already satisfied: numpy in ./anaconda3/envs/test/lib/python3.9/site-packages (from pyceres) (2.0.1)
Using cached pyceres-2.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.9 MB)
Installing collected packages: pyceres
Successfully installed pyceres-2.2
(test) shaoliu@cvg-desktop-56:~$ python -c "import pycolmap; print(pycolmap.__version__)"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: generic_type: type "PositiveExponentialManifold" referenced unknown base type "ceres::Manifold"
(test) shaoliu@cvg-desktop-56:~$ pip uninstall pyceres
Found existing installation: pyceres 2.2
Uninstalling pyceres-2.2:
  Would remove:
    /home/shaoliu/anaconda3/envs/test/lib/python3.9/site-packages/pyceres-2.2.dist-info/*
    /home/shaoliu/anaconda3/envs/test/lib/python3.9/site-packages/pyceres.cpython-39-x86_64-linux-gnu.so
    /home/shaoliu/anaconda3/envs/test/lib/python3.9/site-packages/pyceres.libs/libgfortran-040039e1.so.5.0.0
    /home/shaoliu/anaconda3/envs/test/lib/python3.9/site-packages/pyceres.libs/libquadmath-96973f99.so.0.0.0
Proceed (Y/n)? y
  Successfully uninstalled pyceres-2.2
(test) shaoliu@cvg-desktop-56:~$ python -c "import pycolmap; print(pycolmap.__version__)"
3.11.0

From my test this PR would fix the issue.

Crucial issue that we need to keep in mind in the future @sarlinpe @ahojnnes

@B1ueber2y B1ueber2y marked this pull request as draft July 31, 2024 23:34
@B1ueber2y B1ueber2y changed the title Update cibuildwheel to 2.19.2. Update cibuildwheel to 2.19.2 and ci pipeline Aug 1, 2024
@B1ueber2y B1ueber2y marked this pull request as ready for review August 1, 2024 00:26
@B1ueber2y B1ueber2y requested a review from sarlinpe August 1, 2024 00:29
@B1ueber2y B1ueber2y merged commit 5dab798 into cvg:main Aug 1, 2024
6 checks passed
@B1ueber2y B1ueber2y deleted the fix/ci branch August 1, 2024 08:20
@B1ueber2y B1ueber2y removed the request for review from sarlinpe August 1, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants