Update logging

cvg · Feb 2, 2024 · 31d79b3 · 31d79b3
1 parent 9296755
commit 31d79b3
Show file tree

Hide file tree

Showing 9 changed files with 168 additions and 177 deletions.
diff --git a/_pyceres/core/cost_functions.h b/_pyceres/core/cost_functions.h
@@ -1,7 +1,7 @@
 #pragma once
 
 #include "_pyceres/helpers.h"
-#include "_pyceres/log_exceptions.h"
+#include "_pyceres/logging.h"
 
 #include <ceres/ceres.h>
 #include <pybind11/pybind11.h>

diff --git a/_pyceres/core/covariance.h b/_pyceres/core/covariance.h
@@ -1,7 +1,7 @@
 #pragma once
 
 #include "_pyceres/helpers.h"
-#include "_pyceres/log_exceptions.h"
+#include "_pyceres/logging.h"
 
 #include <ceres/ceres.h>
 #include <pybind11/pybind11.h>

diff --git a/_pyceres/core/loss_functions.h b/_pyceres/core/loss_functions.h
@@ -1,7 +1,7 @@
 #pragma once
 
 #include "_pyceres/helpers.h"
-#include "_pyceres/log_exceptions.h"
+#include "_pyceres/logging.h"
 
 #include <string>
 
@@ -29,7 +29,7 @@ class PyLossFunction : public ceres::LossFunction {
     if (overload) {
       overload.operator()(sq_norm, out_arr);
     } else {
-      THROW_EXCEPTION(std::runtime_error, "<Evaluate> not implemented.")
+      LOG_FATAL_THROW(std::runtime_error) << "<Evaluate> not implemented.";
     }
   }
 

diff --git a/_pyceres/core/manifold.h b/_pyceres/core/manifold.h
@@ -1,7 +1,7 @@
 #pragma once
 
 #include "_pyceres/helpers.h"
-#include "_pyceres/log_exceptions.h"
+#include "_pyceres/logging.h"
 
 #include <ceres/ceres.h>
 #include <pybind11/pybind11.h>
@@ -14,23 +14,25 @@ class PyManifold : public ceres::Manifold {
   bool Plus(const double* x,
             const double* delta,
             double* x_plus_delta) const override {
-    THROW_EXCEPTION(std::runtime_error, "<Plus> not implemented.");
+    LOG_FATAL_THROW(std::runtime_error) << "<Plus> not implemented.";
     return true;
   }
 
   bool PlusJacobian(const double* x, double* jacobian) const override {
-    THROW_EXCEPTION(std::runtime_error, "<PlusJacobian> not implemented.");
+    LOG_FATAL_THROW(std::runtime_error) << "<PlusJacobian> not implemented.";
+    return true;
   }
 
   bool Minus(const double* y,
              const double* x,
              double* y_minus_x) const override {
-    THROW_EXCEPTION(std::runtime_error, "<Minus> not implemented.");
+    LOG_FATAL_THROW(std::runtime_error) << "<Minus> not implemented.";
     return true;
   }
 
   bool MinusJacobian(const double* x, double* jacobian) const override {
-    THROW_EXCEPTION(std::runtime_error, "<MinusJacobian> not implemented.");
+    LOG_FATAL_THROW(std::runtime_error) << "<MinusJacobian> not implemented.";
+    return true;
   }
 
   // Size of x.

diff --git a/_pyceres/core/problem.h b/_pyceres/core/problem.h
@@ -2,7 +2,7 @@
 
 #include "_pyceres/core/wrappers.h"
 #include "_pyceres/helpers.h"
-#include "_pyceres/log_exceptions.h"
+#include "_pyceres/logging.h"
 
 #include <ceres/ceres.h>
 #include <pybind11/pybind11.h>

diff --git a/_pyceres/core/solver.h b/_pyceres/core/solver.h
@@ -1,7 +1,7 @@
 #pragma once
 
 #include "_pyceres/helpers.h"
-#include "_pyceres/log_exceptions.h"
+#include "_pyceres/logging.h"
 
 #include <ceres/ceres.h>
 #include <pybind11/pybind11.h>

diff --git a/_pyceres/core/types.h b/_pyceres/core/types.h
@@ -1,7 +1,7 @@
 #pragma once
 
 #include "_pyceres/helpers.h"
-#include "_pyceres/log_exceptions.h"
+#include "_pyceres/logging.h"
 
 #include <ceres/ceres.h>
 #include <ceres/normal_prior.h>

diff --git a/_pyceres/log_exceptions.h b/_pyceres/log_exceptions.h