Added SIFT features using PyCOLMAP. #69
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a simple interface for VLFeat SIFT from PyCOLMAP.
There might some issue with top keypoints selection - I opened an issue on the PyCOLMAP repository to follow up colmap/pycolmap#8.
I get the following results on South-Building without image downsampling and
max_keypoints=10000
(to avoid GPU memory issues during matching):which seems reasonable 😄.