Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Add option to build static binaries #113

Merged
merged 3 commits into from
Feb 6, 2025
Merged

cmake: Add option to build static binaries #113

merged 3 commits into from
Feb 6, 2025

Conversation

daniel-larraz
Copy link
Contributor

No description provided.

hansjoergschurr
hansjoergschurr approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@hansjoergschurr hansjoergschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One spacing issue and maybe another option name would be better suited?

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
daniel-larraz and others added 2 commits February 4, 2025 14:07
@daniel-larraz @hansjoergschurr
Fix space
34b466b 
Co-authored-by: Hans-Jörg <hansjoergschurr@users.noreply.github.com>
@daniel-larraz
Change CMake option name to BUILD_STATIC
15186b2
@hansjoergschurr
Copy link
Contributor

Thanks, this looks great now.

@daniel-larraz daniel-larraz merged commit a45883e into main Feb 6, 2025
20 checks passed
@daniel-larraz daniel-larraz deleted the static-build branch February 6, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansjoergschurr hansjoergschurr hansjoergschurr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-larraz @hansjoergschurr