Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search to organization page #9151

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Added search to organization page #9151

wants to merge 11 commits into from

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Feb 26, 2025

Motivation and context

This PR adds a search and filtering features to Organization page. Using search we can quickly find members by username.
org-search

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov added the ui/ux label Feb 26, 2025
@klakhov klakhov requested a review from bsekachev as a code owner February 26, 2025 10:34
@bsekachev
Copy link
Member

Perhaps we need to re-use SortingComponent and FilteringComponent also to implement the same view as on other pages.
Thus we may not only search by username, but also filter/sort by membership types, invitation status, invite/join date.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.34%. Comparing base (6cefd3f) to head (851862b).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9151   +/-   ##
========================================
  Coverage    73.33%   73.34%           
========================================
  Files          448      449    +1     
  Lines        45868    45871    +3     
  Branches      3915     3915           
========================================
+ Hits         33636    33642    +6     
+ Misses       12232    12229    -3     
Components Coverage Δ
cvat-ui 77.12% <100.00%> (+0.01%) ⬆️
cvat-server 70.31% <ø> (ø)

@klakhov klakhov requested a review from nmanovic as a code owner February 28, 2025 08:15
@klakhov
Copy link
Contributor Author

klakhov commented Feb 28, 2025

Updated PR to use also filtering and sorting components

Copy link

sonarqubecloud bot commented Mar 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants