Skip to content

Support multiple images update #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

gfronza
Copy link

@gfronza gfronza commented Oct 22, 2016

First of all, thanks for this nice project! It already helped me a lot!

These changes add the possibility of updating multiple containers of the given task definition in a single deployment. For that, I had to replace the --image argument for container_image (multiple values are allowed).

Without this, task definitions with multiple containers could not be updated all at once. Plus, it was always replacing the image of the first container (containerDefinitions[0]).

Thanks again.

@coveralls
Copy link

coveralls commented Oct 22, 2016

Coverage Status

Coverage increased (+1.5%) to 51.079% when pulling f00a841 on gfronza:master into 3f282cd on cuttlesoft:master.

@coveralls
Copy link

coveralls commented Oct 24, 2016

Coverage Status

Coverage increased (+0.05%) to 49.65% when pulling e5311cd on gfronza:master into 3f282cd on cuttlesoft:master.

@frankV
Copy link
Member

frankV commented Oct 26, 2016

Hey @gfronza thanks for this. @katie7r and I will review and merge this in ASAP.

@coveralls
Copy link

coveralls commented Nov 4, 2016

Coverage Status

Coverage increased (+0.7%) to 50.345% when pulling 2192227 on gfronza:master into 3f282cd on cuttlesoft:master.

@coveralls
Copy link

coveralls commented Nov 4, 2016

Coverage Status

Coverage increased (+0.7%) to 50.345% when pulling b064dae on gfronza:master into 3f282cd on cuttlesoft:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants