Upgrade to Swift 5 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move PersonaKit Dependencies to Podspec Remove unused Dependency Bump Version to 2.3.2
jpbernius
commented
May 16, 2019
| @@ -177,7 +177,3 @@ extension PKSession { | |||
| return numberOfShortVisits > 0 | |||
| } | |||
| } | |||
|
|
|||
| extension PKSession: Identifiable { | |||
There was a problem hiding this comment.
@ffittschen Can you confirm that this can be deleted safely?
There was a problem hiding this comment.
@jpbernius Yes, seems like it was unused
There was a problem hiding this comment.
I actually can't remember why the /Storage was added in the first place
There was a problem hiding this comment.
Thanks for your Feedback @ffittschen! I just removed PersonaKit/Storage/* in e91e057 and it still builds, so I guess this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move PersonaKit Dependencies to Podspec
Remove unused Dependency
Bump Version to 2.3.2