Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tray icon #149

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Fix tray icon #149

merged 4 commits into from
Feb 10, 2025

Conversation

alldevic
Copy link
Contributor

@alldevic alldevic commented Feb 7, 2025

Possible fix for #83, #140, #144, #147

@alldevic alldevic mentioned this pull request Feb 7, 2025
Comment on lines +115 to +116
- "name": "YandexMusic",
+ "name": "yandex-music",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the freedesktop standard, the .desktop file name must match the app_id. KDE follows this standard.

Copy link
Contributor

@ein-shved ein-shved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check on Nixos - tray works, all files seems correct. Looks good to me! Thank you!

@cucumber-sp cucumber-sp merged commit 59ed7d6 into cucumber-sp:master Feb 10, 2025
1 of 2 checks passed
@alldevic alldevic deleted the fix-tray-icon branch February 14, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants