Skip to content

Commit

Permalink
Use std::io::IsTerminal instead of is_terminal crate (#288)
Browse files Browse the repository at this point in the history
- bump up MSRV to 1.70.0
  • Loading branch information
SonnyX authored Jun 29, 2023
1 parent 1b8b615 commit d7179de
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
strategy:
fail-fast: false
matrix:
msrv: ["1.65.0"]
msrv: ["1.70.0"]
crate:
- cucumber-codegen
- cucumber
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ All user visible changes to `cucumber` crate will be documented in this file. Th
- Added `Log` variant to `event::Scenario`. ([#258])
- Added `embeddings` field to `writer::json::Step` and `writer::json::HookResult`. ([#261])
- Added `report_time` field to `writer::libtest::Cli`. ([#264], [#265])
- Bumped up [MSRV] to 1.70 for using the `IsTerminal` trait from `std`. ([#288])

### Added

Expand All @@ -33,6 +34,7 @@ All user visible changes to `cucumber` crate will be documented in this file. Th
[#265]: /../../pull/265
[#272]: /../../discussions/272
[#273]: /../../pull/273
[#288]: /../../pull/288



Expand Down
3 changes: 1 addition & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "cucumber"
version = "0.19.1"
edition = "2021"
rust-version = "1.65"
rust-version = "1.70"
description = """\
Cucumber testing framework for Rust, with async support. \
Fully native, no external test runners or dependencies.\
Expand Down Expand Up @@ -51,7 +51,6 @@ futures = "0.3.17"
gherkin = "0.13"
globwalk = "0.8.1"
humantime = "2.1"
is-terminal = "0.4.4"
itertools = "0.11"
lazy-regex = "2.5"
linked-hash-map = "0.5.3"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Cucumber testing framework for Rust
===================================

[![crates.io](https://img.shields.io/crates/v/cucumber.svg?maxAge=2592000 "crates.io")](https://crates.io/crates/cucumber)
[![Rust 1.65+](https://img.shields.io/badge/rustc-1.65+-lightgray.svg "Rust 1.65+")](https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html)
[![Rust 1.70+](https://img.shields.io/badge/rustc-1.70+-lightgray.svg "Rust 1.70+")](https://blog.rust-lang.org/2023/06/01/Rust-1.70.0.html)
[![Unsafe Forbidden](https://img.shields.io/badge/unsafe-forbidden-success.svg "Unsafe forbidden")](https://github.com/rust-secure-code/safety-dance)
[![CI](https://github.com/cucumber-rs/cucumber/workflows/CI/badge.svg?branch=main "CI")](https://github.com/cucumber-rs/cucumber/actions?query=workflow%3ACI+branch%3Amain)
[![Rust docs](https://docs.rs/cucumber/badge.svg "Rust docs")](https://docs.rs/cucumber)
Expand Down
5 changes: 5 additions & 0 deletions codegen/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,16 @@ All user visible changes to `cucumber-codegen` crate will be documented in this

[Milestone](/../../milestone/24)

### BC Breaks

- Bumped up [MSRV] to 1.70 for using the `IsTerminal` trait from `std`. ([#288])

### Changed

- Switched to 2.0 version of [`syn`]. ([#266])

[#266]: /../../pull/266
[#288]: /../../pull/288



Expand Down
2 changes: 1 addition & 1 deletion codegen/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "cucumber-codegen"
version = "0.19.1" # should be the same as main crate version
edition = "2021"
rust-version = "1.65"
rust-version = "1.70"
description = "Code generation for `cucumber` crate."
license = "MIT OR Apache-2.0"
authors = [
Expand Down
2 changes: 1 addition & 1 deletion codegen/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
========================

[![crates.io](https://img.shields.io/crates/v/cucumber-codegen.svg?maxAge=2592000 "crates.io")](https://crates.io/crates/cucumber-codegen)
[![Rust 1.65+](https://img.shields.io/badge/rustc-1.65+-lightgray.svg "Rust 1.65+")](https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html)
[![Rust 1.70+](https://img.shields.io/badge/rustc-1.70+-lightgray.svg "Rust 1.70+")](https://blog.rust-lang.org/2023/06/01/Rust-1.70.0.html)
[![Unsafe Forbidden](https://img.shields.io/badge/unsafe-forbidden-success.svg "Unsafe forbidden")](https://github.com/rust-secure-code/safety-dance)
[![CI](https://github.com/cucumber-rs/cucumber/workflows/CI/badge.svg?branch=main "CI")](https://github.com/cucumber-rs/cucumber/actions?query=workflow%3ACI+branch%3Amain)
[![Rust docs](https://docs.rs/cucumber-codegen/badge.svg "Rust docs")](https://docs.rs/cucumber-codegen)
Expand Down
7 changes: 5 additions & 2 deletions src/writer/out.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,14 @@

//! Tools for writing output.
use std::{borrow::Cow, io, mem, str};
use std::{
borrow::Cow,
io::{self, IsTerminal},
mem, str,
};

use console::Style;
use derive_more::{Deref, DerefMut, Display, From, Into};
use is_terminal::IsTerminal;

use super::Coloring;

Expand Down

0 comments on commit d7179de

Please sign in to comment.