Skip to content

fix(schema-compiler): Fix rendered references for preaggregations with join paths #9528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Fixes rendered references to include both full join path and regular member path as keys.
Without this SQL to read from pre-aggregation table would render members as a regular cube_table.member_sql expressions

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.54%. Comparing base (044341e) to head (3d13ce5).

Files with missing lines Patch % Lines
...bejs-schema-compiler/src/adapter/CubeStoreQuery.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9528      +/-   ##
==========================================
+ Coverage   57.50%   57.54%   +0.03%     
==========================================
  Files         165      165              
  Lines       13504    13516      +12     
  Branches     2278     2278              
==========================================
+ Hits         7766     7778      +12     
  Misses       5430     5430              
  Partials      308      308              
Flag Coverage Δ
cube-backend 57.54% <94.44%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcheshkov mcheshkov force-pushed the fix-preagg-join-path-references branch from fb668d4 to 4632315 Compare April 29, 2025 15:24
@mcheshkov mcheshkov force-pushed the fix-preagg-join-path-references branch from 4632315 to 3d13ce5 Compare April 30, 2025 16:35
@mcheshkov mcheshkov marked this pull request as ready for review April 30, 2025 16:56
@mcheshkov mcheshkov requested a review from a team as a code owner April 30, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant