Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deployment stability #444

Merged
merged 5 commits into from
Jan 25, 2025
Merged

Improve deployment stability #444

merged 5 commits into from
Jan 25, 2025

Conversation

pandatix
Copy link
Member

@pandatix pandatix commented Jan 25, 2025

In this PR I do not focus on improving features nor configurations. I rather improve the deployment stability through:

  • a new /healthcheck endpoint that returns the current status of Chall-Manager and the underlying etcd cluster if configured. This enable the janitor to not start until CM is ready, so avoid useless restarts.
  • a new Pulumi stack configuration janitor.mode to define whether to use the janitor in cron or ticker mode ; and a janitor.ticker to configure the tick frequency.
  • a new Pulumi check for the services.ChallManager that looks for inconsistencies in the configuration, like replicas without an etcd cluster (no consensus can be established thus could not guarantee consistency).
  • better testing strategies with the use of both assert and require rather than only dealing with assertions when requirements must be fulfilled

Solves #402

@pandatix pandatix added enhancement New feature or request dependencies Pull requests that update a dependency file go Pull requests that update Go code chall-manager Related to chall-manager chall-manager-janitor Related to chall-manager-janitor labels Jan 25, 2025
@pandatix pandatix requested a review from NicoFgrx January 25, 2025 21:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12968475748

Details

  • 0 of 75 (0.0%) changed or added relevant lines in 4 files are covered.
  • 29 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/server.go 0 1 0.0%
cmd/chall-manager/main.go 0 3 0.0%
server/healthcheck.go 0 34 0.0%
cmd/chall-manager-janitor/main.go 0 37 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/chall-manager-janitor/main.go 29 0.0%
Totals Coverage Status
Change from base Build 12965550824: 0.0%
Covered Lines: 0
Relevant Lines: 4902

💛 - Coveralls

Copy link
Member

@NicoFgrx NicoFgrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pandatix pandatix merged commit 58fb371 into main Jan 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chall-manager Related to chall-manager chall-manager-janitor Related to chall-manager-janitor dependencies Pull requests that update a dependency file enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants