Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I do not focus on improving features nor configurations. I rather improve the deployment stability through:
/healthcheck
endpoint that returns the current status of Chall-Manager and the underlying etcd cluster if configured. This enable the janitor to not start until CM is ready, so avoid useless restarts.janitor.mode
to define whether to use the janitor in cron or ticker mode ; and ajanitor.ticker
to configure the tick frequency.services.ChallManager
that looks for inconsistencies in the configuration, like replicas without an etcd cluster (no consensus can be established thus could not guarantee consistency).assert
andrequire
rather than only dealing with assertions when requirements must be fulfilledSolves #402