Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ingress exposure missing information for it to work #440

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

pandatix
Copy link
Member

This PR solves the issue we encountered when working on the Hack'lantique 2025.

We were not able to create ingresses due to a lack of information : where is the ingress running ?
Due to no answers available, we could not build the NetworkPolicy that accepts traffic from the IngressController toward the challenge pods.

In this PR I solve this issue by adding two new parameters : IngressNamespace to give the namespace in which the IngressController is running, and IngressLabels to specify a pod in this namespace rather than every one of them.
At the end of the provision function, in the exposure switch, I combine them to create the required NetworkPolicy.
It was the occasion to move around some specific code for NodePorts.

I update the webdoc to document those new infos 😉

@pandatix pandatix added documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code sdk Related to chall-manager SDK labels Jan 25, 2025
@pandatix pandatix requested a review from NicoFgrx January 25, 2025 12:05
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12964742938

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 12832929170: 0.0%
Covered Lines: 0
Relevant Lines: 4847

💛 - Coveralls

Copy link
Member

@NicoFgrx NicoFgrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pandatix pandatix merged commit 1b3e564 into main Jan 25, 2025
6 checks passed
@pandatix pandatix deleted the sdk/kubernetes.ExposedMonopod branch January 25, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code sdk Related to chall-manager SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants