Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key=value pairs #421

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Add key=value pairs #421

merged 2 commits into from
Jan 17, 2025

Conversation

pandatix
Copy link
Member

This PR is a part of response to #403: it solves the problem of passing key=value pairs to the scenario.

It modifies the underlying datamodel to add them a map[string]string named config that will be passed under the additional key to the scenario thus won't collide with Chall-Manager configurations (e.g. identity).

If also solves a bug where the default value of the update-strategy was not applied before updates.

@pandatix pandatix added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file go Pull requests that update Go code chall-manager Related to chall-manager sdk Related to chall-manager SDK labels Jan 16, 2025
@pandatix pandatix requested a review from NicoFgrx January 16, 2025 08:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12805150309

Details

  • 0 of 122 (0.0%) changed or added relevant lines in 12 files are covered.
  • 6 unchanged lines in 5 files lost coverage.
  • Overall coverage remained the same at 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/v1/instance/query.go 0 1 0.0%
api/v1/instance/retrieve.go 0 1 0.0%
api/v1/challenge/create.go 0 2 0.0%
api/v1/challenge/query.go 0 2 0.0%
api/v1/challenge/retrieve.go 0 2 0.0%
api/v1/instance/create.go 0 8 0.0%
api/v1/instance/instance.pb.go 0 11 0.0%
pkg/iac/stack.go 0 14 0.0%
pkg/iac/update.go 0 15 0.0%
api/v1/challenge/challenge.pb.go 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
api/v1/instance/create.go 1 0.0%
api/v1/challenge/query.go 1 0.0%
api/v1/challenge/update.go 1 0.0%
api/v1/instance/retrieve.go 1 0.0%
api/v1/challenge/retrieve.go 2 0.0%
Totals Coverage Status
Change from base Build 12796579316: 0.0%
Covered Lines: 0
Relevant Lines: 4846

💛 - Coveralls

Copy link
Member

@NicoFgrx NicoFgrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this allow us to send IP or CIDR in additionnal in the plugin and use it for firewalling / netpol.

I open an issue linked to this PR

@pandatix pandatix merged commit 149fd09 into main Jan 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chall-manager Related to chall-manager dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code sdk Related to chall-manager SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants