Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ticker to the janitor #408

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add a ticker to the janitor #408

merged 1 commit into from
Jan 10, 2025

Conversation

pandatix
Copy link
Member

@pandatix pandatix commented Jan 8, 2025

This PR solves #401 by introducing a ticker to the chall-manager-janitor.

Despite it remains not recommended to rely on the ticker but on an external cron, this enable Docker-based setups to use the janitor.

@pandatix pandatix added documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code chall-manager-janitor Related to chall-manager-janitor labels Jan 8, 2025
@pandatix pandatix requested a review from NicoFgrx January 8, 2025 09:21
@coveralls
Copy link

coveralls commented Jan 8, 2025

Pull Request Test Coverage Report for Build 12670474833

Details

  • 0 of 65 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/chall-manager-janitor/main.go 0 65 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/chall-manager-janitor/main.go 1 0.0%
Totals Coverage Status
Change from base Build 12666344772: 0.0%
Covered Lines: 0
Relevant Lines: 4757

💛 - Coveralls

Copy link
Member

@NicoFgrx NicoFgrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pandatix pandatix merged commit 35c5928 into main Jan 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chall-manager-janitor Related to chall-manager-janitor documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants