Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scipy to <1.12 #279

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix scipy to <1.12 #279

merged 2 commits into from
Jan 22, 2024

Conversation

RuneDominik
Copy link
Member

With the recent release of scipy 1.12.0 the API of scipy.optimize.RootResults seems to have changed in a way gammapy does not yet provide. Fixing scipy to 1.11.4 should offer a temporary workaround.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (273afd6) 95.40% compared to head (ea1a8d5) 95.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          60       60           
  Lines        3135     3135           
=======================================
  Hits         2991     2991           
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe maxnoe merged commit 0059d3b into main Jan 22, 2024
9 of 10 checks passed
@maxnoe maxnoe deleted the fix_scipy_vers branch January 22, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants