Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated DIRAC endpoints in Singularity/Apptainer containers #92

Conversation

jlenain
Copy link
Collaborator

@jlenain jlenain commented Jan 25, 2024

This PR should solve #91.

…tained within DIRAC. This caused DIRAC to be pinned to version <= 7.* while we now need DIRAC 8.* for the last updated CTADIRAC version with recent endpoints when building our container.
@jlenain jlenain linked an issue Jan 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (270c103) 30.55% compared to head (4779e5b) 30.75%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/nectarchain/data/management.py 20.00% 24 Missing ⚠️
src/nectarchain/utils/logger.py 50.00% 9 Missing ⚠️
src/nectarchain/utils/io.py 52.94% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   30.55%   30.75%   +0.19%     
==========================================
  Files          58       60       +2     
  Lines        3701     3762      +61     
==========================================
+ Hits         1131     1157      +26     
- Misses       2570     2605      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlenain jlenain self-assigned this Jan 25, 2024
@jlenain
Copy link
Collaborator Author

jlenain commented Jan 25, 2024

Manually self-reviewing this now.

@jlenain jlenain merged commit be261aa into cta-observatory:master Jan 25, 2024
12 checks passed
@jlenain jlenain deleted the 91-outdated-dirac-endpoints-in-singularityapptainer-containers branch January 25, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated DIRAC endpoints in Singularity/Apptainer containers
1 participant