support boot mode, legacy or uefi #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csmart
reviewed
Jan 3, 2024
csmart
reviewed
Jan 3, 2024
| --boot loader.readonly=yes | ||
| --boot loader.type=pflash | ||
| --boot loader.secure=no | ||
| --boot loader=/usr/share/OVMF/OVMF_CODE.secboot.fd |
There was a problem hiding this comment.
is this path always the case on all distros, or does it need to be a var?
There was a problem hiding this comment.
@nsatsia is this path always the case on all distros, or does it need to be a var?
There was a problem hiding this comment.
@nsatsia if it's the same file location on all nodes, we can leave it, but if not we should make it a distro var.
Also, I wonder if we should add the package as dep for each distro...
|
@nsatsia thanks for the contribution! I've left a couple of comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sushy-tools as used with K8s Metal3 requires UEFI booting to support virtual-CD mounting via Redfish. This change allows the user to select uefi as the boot mode for the target VMs.