Fixed and/or suppressed GCC 4.8 warnings.

Also recorded in "Known issues" the LLVM-induced invalid memory accesses when compiling with GCC 4.8 on SMP systems.
cslab-ntua · Nov 18, 2014 · 23b909d · 23b909d
1 parent 51c8656
commit 23b909d
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 13 deletions.
diff --git a/README b/README
@@ -221,6 +221,10 @@ such problems.
 GCC versions 4.6.1 and 4.8.2 are not currently supported for compiling the
 library.
 
+Some tests may crash when compiling with GCC 4.8 on SMP systems. The source of
+violating instructions was tracked down inside LLVM, so we recommend using
+GCC <= 4.7 for SMP systems.
+
 ==========
 8. LICENSE
 ==========

diff --git a/include/Makefile.am b/include/Makefile.am
@@ -25,7 +25,6 @@ nobase_include_HEADERS = \
 	sparsex/internals/Barrier.hpp \
 	sparsex/internals/Compiler.hpp \
 	sparsex/internals/Csr.hpp \
-	sparsex/internals/CsrIterator.hpp \
 	sparsex/internals/CsxBuild.hpp \
 	sparsex/internals/CsxGetSet.hpp \
 	sparsex/internals/Csx.hpp \

diff --git a/m4check/ax_compilers.m4 b/m4check/ax_compilers.m4
@@ -254,12 +254,12 @@ case "$ax_build_mode" in
     "debug")
         # undefine NDEBUG; LLVM doesn't want it
         ax_pkg_cppflags="-UNDEBUG -DSPX_DEBUG=1"
-        ax_pkg_cxxflags="-g -O0 -std=c++0x -pedantic -fopenmp -Wall -Woverloaded-virtual"
-        ax_pkg_cflags="-g -O0 -std=c99 -pedantic -fopenmp -Wall" ;;
+        ax_pkg_cxxflags="-g -O0 -std=c++0x -pedantic -fopenmp -Wall -Woverloaded-virtual -Wno-unused-local-typedefs"
+        ax_pkg_cflags="-g -O0 -std=c99 -pedantic -fopenmp -Wall -Wno-unused-local-typedefs" ;;
     "release")
         ax_pkg_cppflags="-DNDEBUG"
-        ax_pkg_cxxflags="-O3 -std=c++0x -pedantic -fopenmp -Wall"
-        ax_pkg_cflags="-O3 -std=c99 -pedantic -fopenmp -Wall" ;;
+        ax_pkg_cxxflags="-O3 -std=c++0x -pedantic -fopenmp -Wall -Wno-unused-local-typedefs"
+        ax_pkg_cflags="-O3 -std=c99 -pedantic -fopenmp -Wall -Wno-unused-local-typedefs" ;;
     *)
         AC_MSG_ERROR(
             [@<:@BUG@:>@ should not have entered here: m4_location]) ;;

diff --git a/src/api/Makefile.am b/src/api/Makefile.am
@@ -28,4 +28,5 @@ libsparsex_la_SOURCES = \
 	error.c \
 	matvec.c
 
+libsparsex_la_LDFLAGS = $(AM_LDFLAGS) -version-info 1:0:0
 libsparsex_la_LIBADD = -lsparseximpl
diff --git a/test/src/CsxCheck.cpp b/test/src/CsxCheck.cpp
@@ -23,14 +23,6 @@
 #include <sparsex/internals/Config.hpp>
 #include "CsxCheck.hpp"
 
-static vector_t *x = NULL;
-static vector_t *y = NULL;
-static vector_t **tmp = NULL;
-static size_t no_loops = 0;
-static size_t no_threads = 0;
-static size_t n = 0;
-static float secs = 0.0;
-
 using namespace sparsex::io;
 
 static void csr_spmv(CSR<spx_uindex_t, spx_value_t> *spm, vector_t *in,