Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unclarity of keymaps in replace-confirm window (#11) #27

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix: unclarity of keymaps in replace-confirm window (#11) #27

merged 1 commit into from
Aug 9, 2023

Conversation

chrisgrieser
Copy link
Contributor

fixing this: #11 (comment)

@cshuaimin
Copy link
Owner

cshuaimin commented Aug 9, 2023

Thank you. In the https://github.com/cshuaimin/ssr.nvim/tree/bind-win branch the confirm window uses getchar instead of mapping, and added underlined style to the first character y/n/a/q/l. (That branch is not ready yet, I'm just too busy)

@chrisgrieser
Copy link
Contributor Author

Oh, I see.

I'll wait for the changes to be merged then

@chrisgrieser
Copy link
Contributor Author

Or, I am wondering, could the PR still be merged as a temporary fix maybe until your branch is ready?

@cshuaimin cshuaimin reopened this Aug 9, 2023
@cshuaimin cshuaimin merged commit 5f43976 into cshuaimin:main Aug 9, 2023
@chrisgrieser
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants