Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit *Calls API #2555

Closed
wants to merge 15 commits into from
Closed

Revisit *Calls API #2555

wants to merge 15 commits into from

Conversation

smonicas
Copy link
Contributor

@smonicas smonicas commented Sep 13, 2024

This PR revisits the calls API by changing it to be a list of IR operations, in that way the API should be more flexible and can be used in more places. One exception is for high level calls which is a tuple of Contract - IR because the target contract has some logic to be applied so i preferred to keep this logic in a single place where the high level calls are computed in the node so places that use it don't need to worry about it. One open question is if internal calls should contain solidity calls, this was the old behavior and i did not change it, i'm not sure why given that solidity calls have their own property. Updated some detectors to use the new API which should improve the performance as they don't have to iterate nodes or IRs.

@smonicas smonicas marked this pull request as ready for review September 18, 2024 13:40
@montyly montyly requested a review from elopez as a code owner October 2, 2024 09:35
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ smonicas
✅ dguido
✅ montyly
❌ lint-action
You have signed the CLA already but the status is still pending? Let us recheck it.

@montyly montyly mentioned this pull request Oct 2, 2024
@smonicas smonicas closed this Oct 2, 2024
@smonicas smonicas deleted the dev-revisit-calls-api branch October 2, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants