Let Crystal::EventLoop#close do the actual close (not just cleanup)
#15641
+65
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal refactor to have the `Crystal::EventLoop#close(io)` implementations be responsible from actually closing the file descriptor or socket, not only do some internal cleanup before closing. This will allow the io_uring event loop to close asynchronously for example.
Sija
reviewed
Apr 7, 2025
| @@ -131,7 +126,7 @@ module Crystal::System::FileDescriptor | |||
|
|
|||
| # Clear the @volatile_fd before actually closing it in order to | |||
| # reduce the chance of reading an outdated fd value | |||
| _fd = @volatile_fd.swap(-1) | |||
| return unless _fd = close_volatile_fd? | |||
There was a problem hiding this comment.
Variables marked with leading underscore are conventionally treated as unused, also there's no need to do that here, why not just drop it?
ditto elsewhere
There was a problem hiding this comment.
No idea why it was used in the first place, maybe to convey the difference with the #fd method.
There was a problem hiding this comment.
It's pretty common to shadow the instance variables / getters, though that's a minor suggestion overall.
There was a problem hiding this comment.
We probably should just use fd because we just poisoned @volatile_fd so #fd is invalid now anyway.
straight-shoota
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal refactor to have the
Crystal::EventLoop#close(io)implementations be responsible from actually closing the file descriptor or socket, not only do some internal cleanup before closing. They now follow the abstract methods documentation:This will allow the io_uring event loop to close asynchronously.
Exposes the
#close_volatile_fd?helper on UNIX that will prove helpful in io_uring.Follow-up to #15640
Extracted from #15634