Add Style/HeredocEscape
#580
Open
+155
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobodywasishere
commented
Feb 19, 2025
nobodywasishere
force-pushed
the
nobody/heredoc-escape
branch
from
103518b to
f6268cb
Compare
Sija
requested changes
Feb 28, 2025
nobodywasishere
force-pushed
the
nobody/heredoc-escape
branch
from
f6268cb to
5134398
Compare
Sija
requested changes
Feb 28, 2025
|
|
||
| def test(source, node : Crystal::StringInterpolation) | ||
| return unless (code = node_source(node, source.lines)) && code.starts_with?("<<-") | ||
| # Heredocs without interpolation are always size 1 |
There was a problem hiding this comment.
This comment contradicts the final test case:
it "fails if an escaped heredoc doesn't contain interpolation"There was a problem hiding this comment.
That testcase is checking if you have an escaped heredoc start that's unnecessary (by not having #{} or escape sequences)
nobodywasishere
force-pushed
the
nobody/heredoc-escape
branch
from
5134398 to
28ddd8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #565