chore: make rate limiter fail-open (frain-dev#1950)

Author: jirevwe

cmd/agent/agent.go

@@ -73,12 +73,9 @@ func AddAgentCommand(a *cli.App) *cobra.Command {
 				return err
 			}
 
-			// block the main thread.
-			// trap Ctrl+C and call cancel on the context
-
 			select {
 			case <-quit:
-				cancel()
+				return nil
 			case <-ctx.Done():
 			}
 

internal/pkg/limiter/pg/client.go

@@ -31,21 +31,23 @@ func (p *SlidingWindowRateLimiter) takeToken(ctx context.Context, key string, ra
 
 	tx, err := p.db.GetDB().BeginTxx(ctx, nil)
 	if err != nil {
-		return err
+		log.Infof("ratelimit failed: %v", err)
+		return nil
 	}
 
 	var allowed bool
 	err = tx.QueryRowContext(ctx, `select convoy.take_token($1, $2, $3)::bool;`, key, rate, windowSize).Scan(&allowed)
 	if err != nil {
-		return err
+		log.Infof("ratelimit failed: %v", err)
+		return nil
 	}
 
 	err = tx.Commit()
 	if err != nil {
 		if rollbackErr := tx.Rollback(); rollbackErr != nil {
 			log.Infof("update failed: %v, unable to rollback: %v", err, rollbackErr)
 		}
-		return err
+		return nil
 	}
 
 	if !allowed {