Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise the action space building #30

Open
spMohanty opened this issue Aug 16, 2018 · 2 comments
Open

Standardise the action space building #30

spMohanty opened this issue Aug 16, 2018 · 2 comments

Comments

@spMohanty
Copy link
Member

spMohanty commented Aug 16, 2018 •
edited
Loading

Right now, the way the action space in an environment is built is pretty messy.

The ideal solution would be to delegate the action space building completely to the mission_spec, and have a separate helper function which takes a mission_spec as input and returns all the valid actions.

These actions can be returns as string "commands", and then we simply shape them as gym friendly classes (Discrete, etc etc).

cc. @katja-hofmann @AndKram
@spMohanty
Copy link
Member Author

Related to #24

@spMohanty
Copy link
Member Author

Addressed in b3fe782
Thanks @AndKram
Will keep the issue open until this has been tested a bit more thoroughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spMohanty