tempest: add kibana_version to the identity senction of tempest.conf #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibana_version conf is needed by monasca_log_api_tempest testcases as this key-value pair is added headers of requests to kibana https://opendev.org/openstack/monasca-log-api/src/tag/newton-eol/monasca_log_api_tempest/config.py#L40
toabctl
reviewed
Aug 30, 2019
| @@ -92,6 +92,7 @@ alt_username = <%= @alt_comp_user %> | |||
| alt_tenant_name = <%= @alt_comp_tenant %> | |||
| alt_password = <%= @alt_comp_pass %> | |||
| alt_domain_name = Default | |||
| kibana_version = '4.6.3' | |||
There was a problem hiding this comment.
would it be possible to get the installed kibana version instead of hardcoding the version?
There was a problem hiding this comment.
I am not sure how to carry that version from monasca-server node to controller where the tempest is installed without putting is much effort for SOC7 which I was told is EOL in couple of months from now.
Also Kibana is not something we update frequently so this version wont change as often.
What do you suggest ?
|
Looks good, but needs rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kibana_version conf is needed by monasca_log_api_tempest testcases as
this key-value pair is added headers of requests to kibana
https://opendev.org/openstack/monasca-log-api/src/tag/newton-eol/monasca_log_api_tempest/config.py#L40
sample failure: https://ci.suse.de/job/openstack-mkcloud/8437/consoleText