openstack: Rename SSL options to TLS #1994
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSL is really ancient term, we should use the more common and modern TLS acronym instead.
toabctl
requested changes
Feb 4, 2019
| ca_certs: 'SSL CA Certificates File' | ||
| certfile: 'Server X.509 Certificate (Public) File' | ||
| keyfile: 'Server X.509 Key (Private) File' | ||
| insecure: 'Skip Certificate Validation (self-signed/insecure) (for instance, self-signed)' |
There was a problem hiding this comment.
self-signed is now twice in the text
| ca_certs: 'SSL CA Certificates File' | ||
| certfile: 'Server X.509 Certificate (Public) File' | ||
| keyfile: 'Server X.509 Key (Private) File' | ||
| insecure: 'Skip Certificate Validation (self-signed/insecure) (for instance, self-signed)' |
| ca_certs: 'SSL CA Certificates File' | ||
| certfile: 'Server X.509 Certificate (Public) File' | ||
| keyfile: 'Server X.509 Key (Private) File' | ||
| insecure: 'Skip Certificate Validation (self-signed/insecure) (for instance, self-signed)' |
There was a problem hiding this comment.
same here (I stop here todo that comment. seems to be in all places...)
rhafer
reviewed
Feb 6, 2019
| certfile: 'Server X.509 Certificate (Public) File' | ||
| keyfile: 'Server X.509 Key (Private) File' | ||
| insecure: 'Skip Certificate Validation (self-signed/insecure) (for instance, self-signed)' | ||
| cert_required: 'Certificate Authority (CA) Bundle File Required' |
There was a problem hiding this comment.
Do you know what this option is actually good for? IIRC it was initially intendent for being able to verify client certificates. But we never set any option that does that, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL is really ancient term, we should use the more common
and modern TLS acronym instead.