Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use distroless/static image instead of distroless/base since glibc is not used #88

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

vilmosmartinek
Copy link
Contributor

Description of your changes

This pull request changes the base image in the template to gcr.io/distroless/static-debian12:nonroot.

Fixes #87

I have:

  • Read and followed Crossplane's contribution process.
    - [ ] Added or updated unit tests for my change.

Signed-off-by: Vilmos Martinek <vilmos.martinek@nokia.com>
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, we've merged all the updates to the specific functions that you opened @vilmosmartinek, let's get this update to the template repo merged in too 😉

@jbw976 jbw976 merged commit c877bb9 into crossplane:main Dec 16, 2024
6 checks passed
@jbw976
Copy link
Member

jbw976 commented Dec 17, 2024

All releases with this static distroless change are complete - thanks again @vilmosmartinek for taking the initiative to make this improvement and for testing it to help ensure quality as well! 🙇‍♂️

@vilmosmartinek vilmosmartinek deleted the static-base-image branch January 6, 2025 13:28
@vilmosmartinek
Copy link
Contributor Author

Thank you very much @jbw976 and @phisco for reviewing all these PRs and creating the new releases for each provider! I truly appreciate your help, feedback, and effort in making this improvement possible. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use distroless/static image instead of distroless/base since glibc is not used
2 participants