-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use distroless/static image instead of distroless/base since glibc is not used #88
Conversation
Signed-off-by: Vilmos Martinek <vilmos.martinek@nokia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think this will be a good improvement to make, as briefly discussed on crossplane-contrib/function-auto-ready#49 (review). Thank you for your initiative and thoroughness! 🙇♂️
There's a few PRs now from @vilmosmartinek across the ecosystem of functions to make this same change, so let's test those and build confidence in them, and then we can merge this template change as well.
Other open PRs for this same change:
- Use distroless/static image instead of distroless/base since glibc is not used crossplane-contrib/function-auto-ready#49
- Use distroless/static image instead of distroless/base since glibc is not used crossplane-contrib/function-patch-and-transform#157
- Use distroless/static image instead of distroless/base since glibc is not used crossplane-contrib/function-environment-configs#52
- Use distroless/static image instead of distroless/base since glibc is not used crossplane-contrib/function-go-templating#134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, we've merged all the updates to the specific functions that you opened @vilmosmartinek, let's get this update to the template repo merged in too 😉
Tracking list for the function releases that will include this static distroless change:
|
All releases with this static distroless change are complete - thanks again @vilmosmartinek for taking the initiative to make this improvement and for testing it to help ensure quality as well! 🙇♂️ |
Description of your changes
This pull request changes the base image in the template to
gcr.io/distroless/static-debian12:nonroot
.Fixes #87
I have:
- [ ] Added or updated unit tests for my change.