Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for conferencing_profiles in userinfo endpoint #132

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Added support for conferencing_profiles in userinfo endpoint #132

merged 2 commits into from
Mar 26, 2024

Conversation

lavy-blaggan
Copy link
Contributor

Copy link
Contributor

@CronofyMatt CronofyMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lavy-blaggan,

Thank you for your contribution!

I have taken a moment to review this and it seems that its very nearly there in terms of functionality. Theres just a couple of issues that would need some attention before we could accept this into the SDK.

  • It seems theres a possible infinite loop in the Equals method of the ConferencingProfile class.
  • Theres a couple of CI warnings around invalid CREF tags in some of the doc comments. I think these need the namespace/parent class prefixed onto them to point to the right thing.

Once these issues are resolved we would be happy to accept your contribution.

All the best,
Matt

@lavy-blaggan
Copy link
Contributor Author

lavy-blaggan commented Mar 25, 2024

Hey @lavy-blaggan,

Thank you for your contribution!

I have taken a moment to review this and it seems that its very nearly there in terms of functionality. Theres just a couple of issues that would need some attention before we could accept this into the SDK.

  • It seems theres a possible infinite loop in the Equals method of the ConferencingProfile class.
  • Theres a couple of CI warnings around invalid CREF tags in some of the doc comments. I think these need the namespace/parent class prefixed onto them to point to the right thing.

Once these issues are resolved we would be happy to accept your contribution.

All the best, Matt

Thank you for the feedback, @CronofyMatt.

I have resolved the issues. Let me know if there's anything else.

Cheers,
Lavy

@CronofyMatt
Copy link
Contributor

Hi @lavy-blaggan,

Thanks for getting back to us and making the requested changes. I have given everything another look over and tested out the functionality and can see its working as expected.

I will get this merged now and get it deployed to NuGet.

Thank you again for your contribution!

All the best,
Matt

@CronofyMatt CronofyMatt merged commit 16f3703 into cronofy:master Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants