Automatically lint new PRs #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 31, 2024 22:00
These recent commits are confusing I know, this is related to the "official" ansible-lint github action not being able to find collections that are supposed to be installed by default. I'm having a difficult time understanding where the requirements file will be read, but that is likely because I use a slightly unusual structure for role distribution? This commit uses reference from https://docs.ansible.com/ansible/latest/galaxy/user_guide.html#installing-roles-and-collections-from-the-same-requirements-yml-file
Still don't get where I'm expected to put this.
|
This is related to ansible/ansible-lint#2828 but I can't find a resolution anywhere. I get it, python venvs require careful config, but the project does not provide any guidance on doing it correctly and repeatedly tells us it "just works" like in https://ansible.readthedocs.io/projects/lint/usage/#dependencies-and-requirements. Will likely try a more proper collection layout on a different branch and see if this improves. |
added 16 commits
July 31, 2024 23:22
This commit moves the requirements.yml file back to the root dir (yes, I know I tried this already), and moves the test playbook to the playbooks dir, which is a standard collection root dir. This is meant to see if the playbook.yaml file is being linted without resolving dependencies, whereas a role might not? Note that the docs at https://ansible.readthedocs.io/projects/lint/usage/#dependencies-and-requirements conflict with the docs referenced in previous commits. The ansible-lint docs don't suggest that the requirements.yml file will be detected in roles/<role>/meta/requirements.yml.
Also properly removes playbook.yaml from root as desired in previous commits.
Not sure what is actually in the runner image.
This commit switches to ansible-test instead of ansible-lint due to its availability in the main runner image without the use of the ansible-lint action.
This was a syntax error.
Runner does not have subdirs that are standard with a regular ansible installation.
Looks like it does not support shell variable substitution. Use a hard path for now, we will make this pretty later.
This is needed by ansible-test.
This commit reattempts to use ansible-lint from a shell, but installs it first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
This pull request introduces a new GitHub Actions workflow that runs
ansible-linton pull requests.