Début i18n #250
Début i18n #250
Conversation
translations/messages.fr.yaml
Outdated
| @@ -1 +1,24 @@ | |||
| Contribute: "Contribuez au projet\xA0:" | |||
There was a problem hiding this comment.
you should use lower & snake case
There was a problem hiding this comment.
or camelCame, but without upper case on first letter
There was a problem hiding this comment.
I don't think we need to add \xA0 : if we need to have non-breaking spaces, we should use css instead
There was a problem hiding this comment.
In projects that im working keys are camelCase with kind of namespaces to start the string example :
user.firstName
project.shortTitle
project.title
Thats very convenient when you are looking for existing keys imo
There was a problem hiding this comment.
sure, let's do it! But as you said, the first letter is always a lowercase one
templates/user/index.html.twig
Outdated
|
|
||
| <p>Semaine prochaine : du {{ 'next week' | date('d/m/Y') }} au {{ 'sunday next week' | date('d/m/Y') }}</p> | ||
| <p><a class="btn btn-outline-primary" href="{{ path('user_availability', { week: 'next week'|date('o-\\WW') }) }}" role="button">Mes disponibilités pour la semaine prochaine</a></p> | ||
| <p>{{ 'Week.Next' | trans }} : {{ 'From' | trans }} {{ 'next week' | date('d/m/Y') }} {{ 'To' | trans }} {{ 'sunday next week' | date('d/m/Y') }}</p> |
There was a problem hiding this comment.
you can maybe use a form-to translation with 2 parameters
templates/base.html.twig
Outdated
| @@ -4,7 +4,7 @@ | |||
| <meta charset="UTF-8"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <link rel="shortcut icon" href="/favicon.ico" /> | |||
| <title>ResOP - {% block title %}Welcome!{% endblock %}</title> | |||
| <title>ResOP - {% block title %}{{ 'Welcome' | trans }}!{% endblock %}</title> | |||
There was a problem hiding this comment.
Can you add ResOP into a key ? Like project.short.title or similar
translations/messages.fr.yaml
Outdated
| @@ -1 +1,24 @@ | |||
| Contribute: "Contribuez au projet\xA0:" | |||
There was a problem hiding this comment.
In projects that im working keys are camelCase with kind of namespaces to start the string example :
user.firstName
project.shortTitle
project.title
Thats very convenient when you are looking for existing keys imo
translations/messages.fr.yaml
Outdated
| @@ -1 +1,25 @@ | |||
| Submit: Enregistrer | |||
| action.login: Connexion | |||
There was a problem hiding this comment.
on yaml files, you can use objects:
action:
login:
connect: Connexion
submit: Je me connecte
logout: Déconnexion
...
templates/user/index.html.twig
Outdated
| <h1>Bienvenue, {{ app.user.fullName }}</h1> | ||
| <p>NIVOL : {{ app.user.identificationNumber }}</p> | ||
| <p><a class="btn btn-primary" href="{{ path('user_edit') }}" role="button">Modifier mes informations</a></p> | ||
| <h1>{{ 'nav.welcome' | trans }}, {{ app.user.fullName }}</h1> |
There was a problem hiding this comment.
here you should use a parameter with a %name% parameter, as we won't always have word + , + name.
For example : nav.welcome: Hello %name%.
{{ 'nav.welcome'|trans({'%name%': app.user.fullName)) }}
There was a problem hiding this comment.
|
Thanks @ni-grid |
Je n'ai modifié que quelques fichiers pour valider que c'est bien ce qui est attendu
Ref #223