Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync downstream projects to v1.8 of vocabulary-theme #87

Open
1 task done
possumbilities opened this issue Jan 7, 2025 · 2 comments
Open
1 task done

sync downstream projects to v1.8 of vocabulary-theme #87

possumbilities opened this issue Jan 7, 2025 · 2 comments
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🔒 staff only Restricted to CC staff members 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@possumbilities
Copy link
Contributor

possumbilities commented Jan 7, 2025

Description

vocabulary-theme received changes:

vocabulary-theme needs to be updated to v1.8 in the following projects:

Technical Details

This version makes changes to:

See this detailed PR for relevant changes to HTML implementations that will be relevant.

Implementation

  • I would be interested in implementing this feature.
@possumbilities possumbilities added 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🔒 staff only Restricted to CC staff members labels Jan 7, 2025
@possumbilities possumbilities self-assigned this Jan 7, 2025
@possumbilities
Copy link
Contributor Author

This is presently 🚧 status: blocked Blocked & therefore, not ready for work until it passes final testing and deployment to the Index Project staging/prod environments.

@possumbilities possumbilities moved this to In progress in possumbilities Jan 8, 2025
@possumbilities
Copy link
Contributor Author

possumbilities commented Jan 21, 2025

In testing this release further, there remains a rendering bug in the main content area's overall padding on smaller viewports. (this is not present on the current live site and is likely a regression.

As a result, I'll work to correct this in vocabulary, implement it downstream into index-prototype then vocabulary-theme, and then issue a v1.8.1 of vocabulary-theme.

This will remain 🚧 status: blocked Blocked & therefore, not ready for work until that's done, and the Issue will be amended from v1.8 to v1.8.1 at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🔒 staff only Restricted to CC staff members 🚧 status: blocked Blocked & therefore, not ready for work
Projects
Status: In progress
Development

No branches or pull requests

1 participant